submodules: update clippy from 29bf75cd to 1df5766c #56565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes clippy toolstate. Changes: ```` Remove -preview suffix from README rustup clippy build with latest rustc (breakage due to rust-lang@08f8fae ) Forgot to remove some debugging code ... Improved code noted by clippy. Fix bug in `implicit_return`. Bug was already covered by test, but test was not checked for. fix rust-lang#3482 and add ui test for it Don't change current working directory of cargo tests Use cargo's "PROFILE" envvar and set CLIPPY_DOGFOOD Use dogfood_runner for deterministic test ordering Remove unnecessary documentation Fix dogfood tests. Added additional reasoning to `Why is this bad?`. Added comment to explain usage of MIR. Renamed to `implicit_return`. Covered all other kinds besides `ExprKind::Lit`. Added check for replacing `break` with `return`. Appeasing the Test Gods. Seems I'm not smart enough to run the tests locally before committing. Renamed `forced_return` to `missing_returns`. Better clarification in the docs. Ran `update_lints`. Added `FORCED_RETURN` lint. ````
|
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=1 |
|
📌 Commit 078984d has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 6, 2018
submodules: update clippy from 29bf75c to 1df5766 Fixes clippy toolstate. Changes: ```` Remove -preview suffix from README rustup clippy build with latest rustc (breakage due to 08f8fae ) Forgot to remove some debugging code ... Improved code noted by clippy. Fix bug in `implicit_return`. Bug was already covered by test, but test was not checked for. fix #3482 and add ui test for it Don't change current working directory of cargo tests Use cargo's "PROFILE" envvar and set CLIPPY_DOGFOOD Use dogfood_runner for deterministic test ordering Remove unnecessary documentation Fix dogfood tests. Added additional reasoning to `Why is this bad?`. Added comment to explain usage of MIR. Renamed to `implicit_return`. Covered all other kinds besides `ExprKind::Lit`. Added check for replacing `break` with `return`. Appeasing the Test Gods. Seems I'm not smart enough to run the tests locally before committing. Renamed `forced_return` to `missing_returns`. Better clarification in the docs. Ran `update_lints`. Added `FORCED_RETURN` lint. ```` r? @oli-obk
|
☀️ Test successful - status-appveyor, status-travis |
|
📣 Toolstate changed by #56565! Tested on commit 118e052. 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Dec 6, 2018
Tested on commit rust-lang/rust@118e052. Direct link to PR: <rust-lang/rust#56565> 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes clippy toolstate.
Changes:
r? @oli-obk