Skip to content

Conversation

pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented Dec 4, 2018

This PR cherry-picks the following PRs to stable:

The changes will be included in the final 1.31.0 binary (to avoid a point release). To deploy the build to dev-static the old manifest needs to be removed from the bucket after the PR is merged.

cc @rust-lang/core @rust-lang/release @rust-lang/compiler
r? @alexcrichton

oli-obk and others added 3 commits December 4, 2018 22:12
There are two `TyCtxt`s, one global, one local. Methods must be called
on the right one, as they differ by invariant lifetimes.
@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2018
@alexcrichton
Copy link
Member

@bors: r+ p=1000

@bors
Copy link
Collaborator

bors commented Dec 4, 2018

📌 Commit f41b48a has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2018
@bors
Copy link
Collaborator

bors commented Dec 4, 2018

⌛ Testing commit f41b48a with merge 55a0c797db19e2add2c84e58d879c06553a74238...

and update it so that links are correct
@pietroalbini
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 4, 2018
@pietroalbini
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 4, 2018
@pietroalbini
Copy link
Member Author

Added #56519

@bors r+ p=1000

@bors
Copy link
Collaborator

bors commented Dec 4, 2018

📌 Commit 6d54f6d has been approved by pietroalbini

@bors
Copy link
Collaborator

bors commented Dec 4, 2018

⌛ Testing commit 6d54f6d with merge abe02ce...

bors added a commit that referenced this pull request Dec 4, 2018
[stable] Add a few critical fixes to the 1.31.0 release

This PR cherry-picks the following PRs to stable:

* #56467: Bump stack size to 32MB
* #56486: Propagate all closure requirements to the caller
* #56519: update edition guide

The changes will be included in the final 1.31.0 binary (to avoid a point release). To deploy the build to dev-static the old manifest needs to be removed from the bucket after the PR is merged.

cc @rust-lang/core @rust-lang/release @rust-lang/compiler
r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Dec 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pietroalbini
Pushing abe02ce to stable...

@bors bors merged commit 6d54f6d into rust-lang:stable Dec 5, 2018
@Geal
Copy link
Contributor

Geal commented Dec 5, 2018

this might fix #55390, I'll test with this nightly

@pietroalbini pietroalbini deleted the stable-additions branch December 5, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants