Skip to content

Conversation

alexreg
Copy link
Contributor

@alexreg alexreg commented Sep 27, 2018

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 27, 2018
@rust-highfive

This comment has been minimized.

@davidtwco
Copy link
Member

LGTM but I'll assign to @estebank since they commented on the issue and might have some thoughts.

r? @estebank

@rust-highfive rust-highfive assigned estebank and unassigned davidtwco Sep 27, 2018
@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 27, 2018

📌 Commit 4151de4 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Sep 29, 2018
…tebank

Added help message for `self_in_typedefs` feature gate

Fixes rust-lang#54563.

CC @Centril @estebank @leonardo-m
bors added a commit that referenced this pull request Sep 29, 2018
Rollup of 8 pull requests

Successful merges:

 - #54564 (Add 1.29.1 release notes)
 - #54567 (Include path in stamp hash for debuginfo tests)
 - #54577 (rustdoc: give proc-macros their own pages)
 - #54590 (std: Don't let `rust_panic` get inlined)
 - #54598 (Remove useless lifetimes from `Pin` `impl`s.)
 - #54604 (Added help message for `self_in_typedefs` feature gate)
 - #54635 (Improve docs for std::io::Seek)
 - #54645 (Compute Android gdb version in compiletest)
@bors bors merged commit 4151de4 into rust-lang:master Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants