resolve: Continue search in outer scopes after applying derive resolution fallback #53516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
petrochenkov
added
the
beta-nominated
estebank
reviewed
Aug 20, 2018
| self.hygienic_lexical_parent_with_compatibility_fallback(module, &mut ident.span, | ||
| node_id) | ||
| node_id, &mut poisoned) |
There was a problem hiding this comment.
I find mutable arguments to be a bit stylistically unappealing, in Rust in particular. You could do something like the following:
if let ... {
let (module, poisoned_opt) = self.hygienic_lexical_parent_with_compatibility_fallback(...);
poisoned = poisoned_opt;
module
} else {
although I'm not seeing it as much of an improvement...
|
@bors r+ |
|
📌 Commit 7e8825b has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 22, 2018
resolve: Continue search in outer scopes after applying derive resolution fallback Fixes #53263
|
☀️ Test successful - status-appveyor, status-travis |
pietroalbini
added
the
T-compiler
|
Accepting for beta backport: regression fix. cc @rust-lang/compiler |
nikomatsakis
added
the
beta-accepted
pietroalbini
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Aug 25, 2018
[beta] Rollup backports Merged and approved: * #53559: add macro check for lint * #53509: resolve: Reject some inaccessible candidates sooner during import resolution * #53239: rustc_codegen_llvm: Restore the closure env alloca hack for LLVM 5. * #53235: Feature gate where clauses on associated type impls * #53516: resolve: Continue search in outer scopes after applying derive resolution fallback r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53263