Skip to content

Revert #51662 #51680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2018
Merged

Revert #51662 #51680

merged 1 commit into from
Jun 21, 2018

Conversation

Mark-Simulacrum
Copy link
Member

This reverts that PR because it was never intended to merge into the master branch.

@Mark-Simulacrum
Revert "Auto merge of rust-lang#51662 - Mark-Simulacrum:beta-next, r=…
43557fc 
…Mark-Simulacrum"

This reverts commit fff1aba, reversing
changes made to 01172a7.
@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2018
@Mark-Simulacrum
Copy link
Member Author

@bors r+ p=100

@bors
Copy link
Collaborator

bors commented Jun 21, 2018

📌 Commit 43557fc has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2018
@kennytm
Copy link
Member

kennytm commented Jun 21, 2018

We should ask highfive to complain if the title contains the word [beta] but the target branch isn't beta (similar for [stable]) 😄

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 21, 2018
Merged
@bors
Copy link
Collaborator

bors commented Jun 21, 2018

⌛ Testing commit 43557fc with merge f790780...

bors added a commit that referenced this pull request Jun 21, 2018
@bors
Auto merge of #51680 - Mark-Simulacrum:acc-revert, r=Mark-Simulacrum
f790780 
Revert #51662

This reverts that PR because it was never intended to merge into the master branch.
@kennytm kennytm mentioned this pull request Jun 21, 2018
Merged
@bors
Copy link
Collaborator

bors commented Jun 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing f790780 to master...

@bors bors merged commit 43557fc into rust-lang:master Jun 21, 2018
@ishitatsuyuki ishitatsuyuki mentioned this pull request Jun 22, 2018
Closed
@Mark-Simulacrum Mark-Simulacrum deleted the acc-revert branch June 8, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mark-Simulacrum @rust-highfive @bors @kennytm @aturon