Skip to content

Conversation

@kennytm
Copy link
Member

@kennytm kennytm commented May 21, 2018

#43278 has been fixed, so we don't need this struct anymore.

(Actually we don't even need .unwrap() thanks to #![feature(exhaustive_patterns)])

@rust-highfive
Copy link
Contributor

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2018
Copy link
Member

@scottmcm scottmcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kennytm!

@shepmaster
Copy link
Member

Ping from triage, @withoutboats !

@TimNN
Copy link
Contributor

TimNN commented Jun 12, 2018

Ping from triage, @withoutboats / @rust-lang/libs, this PR needs your review!

@withoutboats
Copy link
Contributor

@bors r? @sfackler

@sfackler
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 12, 2018

📌 Commit a5f8572 has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2018
@bors
Copy link
Collaborator

bors commented Jun 12, 2018

🔒 Merge conflict

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 12, 2018
@kennytm
Copy link
Member Author

kennytm commented Jun 12, 2018

@bors r=sfackler

@bors
Copy link
Collaborator

bors commented Jun 12, 2018

📌 Commit 8ae1889 has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 12, 2018
@bors
Copy link
Collaborator

bors commented Jun 13, 2018

⌛ Testing commit 8ae1889 with merge 8398ab8...

bors added a commit that referenced this pull request Jun 13, 2018
Replace `core::iter::AlwaysOk<T>` by `Result<T, !>`

#43278 has been fixed, so we don't need this struct anymore.

(Actually we don't even need `.unwrap()` thanks to `#![feature(exhaustive_patterns)]`)
@bors
Copy link
Collaborator

bors commented Jun 13, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 8398ab8 to master...

@bors bors merged commit 8ae1889 into rust-lang:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants