Remove filetime dep from build_helper #49549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retep998
reviewed
Apr 1, 2018
src/bootstrap/util.rs
Outdated
| @@ -45,7 +45,6 @@ pub fn copy(src: &Path, dst: &Path) { | |||
| dst.display(), e) | |||
| } | |||
| let metadata = t!(src.metadata()); | |||
| t!(fs::set_permissions(dst, metadata.permissions())); | |||
There was a problem hiding this comment.
This change seems unrelated?
There was a problem hiding this comment.
Ah, right. It's not needed, but I forgot to remove it from this patch.
Mark-Simulacrum
force-pushed
the
bootstrap-cleanup
branch
from
270ebb9 to
86915dd
Compare
|
@bors: r+ |
|
📌 Commit 86915dd has been approved by |
bors
added
the
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Apr 1, 2018
…r=alexcrichton Remove filetime dep from build_helper r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton