Skip to content

Conversation

nrc
Copy link
Member

@nrc nrc commented Mar 19, 2018

r? @alexcrichton

Update the RLS on beta - the version currently on beta is particularly flakey and I don't want it to hit stable. This is the version currently on nightly (modulo Cargo updates) and seems a lot more stable.

We don't need to roll out a beta release just for this - I don't think the RLS has many beta users.

@Mark-Simulacrum
Copy link
Member

We roll out beta releases on each PR merge anyway. I'm somewhat hesitant to do this the week before the release -- is there a chance we know of the specific commit which will reduce flakiness in RLS, so that we could backport just it?

Otherwise thought this seems fine if it gets past bors.

@nrc
Copy link
Member Author

nrc commented Mar 19, 2018

is there a chance we know of the specific commit which will reduce flakiness in RLS

No, there are a whole bunch of commits which help here, and I'm not sure it is possible (or desirable) to cherry-pick those without the other stuff.

@Mark-Simulacrum
Copy link
Member

Okay. @bors r+ p=3

@bors
Copy link
Collaborator

bors commented Mar 19, 2018

📌 Commit 08a9e27 has been approved by Mark-Simulacrum

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 19, 2018
@bors
Copy link
Collaborator

bors commented Mar 19, 2018

⌛ Testing commit 08a9e27 with merge ef3368a...

bors added a commit that referenced this pull request Mar 19, 2018
Update RLS

r? @alexcrichton

Update the RLS on beta - the version currently on beta is particularly flakey and I don't want it to hit stable. This is the version currently on nightly (modulo Cargo updates) and seems a lot more stable.

We don't need to roll out a beta release just for this - I don't think the RLS has many beta users.
@Mark-Simulacrum
Copy link
Member

@bors retry

Though bors apparently doesn't know it yet, this did fail Appveyor.

@bors
Copy link
Collaborator

bors commented Mar 19, 2018

⌛ Testing commit 08a9e27 with merge b82c4701e2f2518ee04de7c8a35356b185a4d048...

@bors
Copy link
Collaborator

bors commented Mar 19, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2018
@kennytm kennytm changed the title Update RLS [beta] Update RLS Mar 19, 2018
@kennytm
Copy link
Member

kennytm commented Mar 19, 2018

@bors retry

3 hour timeout on asmjs, check i686-pc-windows-msvc, check i686-pc-windows-gnu, the usual suspects.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2018
@bors
Copy link
Collaborator

bors commented Mar 20, 2018

⌛ Testing commit 08a9e27 with merge b16a56de2e85bc84d2d115697a3ab0a21c6f2932...

@bors
Copy link
Collaborator

bors commented Mar 20, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2018
@kennytm
Copy link
Member

kennytm commented Mar 21, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2018
@bors
Copy link
Collaborator

bors commented Mar 21, 2018

⌛ Testing commit 08a9e27 with merge 70ad4bf146636a21f325abccf71da1c79520e50a...

@bors
Copy link
Collaborator

bors commented Mar 21, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 21, 2018
@kennytm
Copy link
Member

kennytm commented Mar 21, 2018

@bors retry treeclosed=30

Lots of network issue when connecting to the GCC FTP server. Figuring out solutions.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2018
kennytm added 2 commits March 22, 2018 13:20
The former seems much more stable, in case the cache becomes invalidated.
@alexcrichton
Copy link
Member

alexcrichton commented Mar 22, 2018

@bors: p=100

This is really cutting it close for a backport as this'll be release to stable basically in a few days, but if we gotta get it in we gotta get it in now.

Added in commits from #49246

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Mar 22, 2018

📌 Commit 07e4c9e has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Mar 22, 2018

⌛ Testing commit 07e4c9e with merge 745ad86...

bors added a commit that referenced this pull request Mar 22, 2018
[beta] Update RLS

r? @alexcrichton

Update the RLS on beta - the version currently on beta is particularly flakey and I don't want it to hit stable. This is the version currently on nightly (modulo Cargo updates) and seems a lot more stable.

We don't need to roll out a beta release just for this - I don't think the RLS has many beta users.
@bors
Copy link
Collaborator

bors commented Mar 23, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 23, 2018
@alexcrichton
Copy link
Member

@bors: retry

/Users/travis/.rvm/gems/ruby-2.2.5/gems/aws-sdk-core-2.6.5/lib/aws-sdk-core/xml/doc_builder.rb:64:in `encode': dlopen(enc/trans/escape.so, 9): image not found - enc/trans/escape.so (LoadError)

wut?!

@kennytm I think we really need to stop using Travis deploy

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2018
@bors
Copy link
Collaborator

bors commented Mar 23, 2018

⌛ Testing commit 07e4c9e with merge 1104e76...

bors added a commit that referenced this pull request Mar 23, 2018
[beta] Update RLS

r? @alexcrichton

Update the RLS on beta - the version currently on beta is particularly flakey and I don't want it to hit stable. This is the version currently on nightly (modulo Cargo updates) and seems a lot more stable.

We don't need to roll out a beta release just for this - I don't think the RLS has many beta users.
@bors
Copy link
Collaborator

bors commented Mar 23, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1104e76 to beta...

@bors bors merged commit 07e4c9e into rust-lang:beta Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants