Skip to content

Fix an accuracy regression in f32::to_degrees #48622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix an accuracy regression in f32::to_degrees #48622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/libcore/num/f32.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,7 @@ impl Float for f32 {
/// Converts to degrees, assuming the number is in radians.
#[inline]
fn to_degrees(self) -> f32 {
// Use a constant for better precision.
const PIS_IN_180: f32 = 57.2957795130823208767981548141051703_f32;
self * PIS_IN_180
(self as f64).to_degrees() as f32
}

/// Converts to radians, assuming the number is in degrees.
Expand Down
4 changes: 4 additions & 0 deletions src/libstd/f32.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1532,6 +1532,10 @@ mod tests {
assert_eq!(inf.to_degrees(), inf);
assert_eq!(neg_inf.to_degrees(), neg_inf);
assert_eq!(1_f32.to_degrees(), 57.2957795130823208767981548141051703);
assert_eq!(f32::consts::FRAC_PI_6.to_degrees(), 30.0f32);
assert_eq!(f32::consts::FRAC_PI_3.to_degrees(), 60.0f32);
assert_eq!(30.0f32.to_degrees().to_radians(), 30.0f32);
assert_eq!(30.0f32.to_radians().to_degrees(), 30.0f32);
}

#[test]
Expand Down