Skip to content

Encode linker arguments as UTF-16 on MSVC platforms #48548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2018
Merged

Encode linker arguments as UTF-16 on MSVC platforms #48548

merged 1 commit into from
Feb 28, 2018

Conversation

alexcrichton
Copy link
Member

This is a forward-port of #48455 to the master branch

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2018
@alexcrichton
Copy link
Member Author

@bors: r+

Carrying over r+ from previous PR

(cc @Mark-Simulacrum)

@bors
Copy link
Collaborator

bors commented Feb 26, 2018

📌 Commit 5db73fc has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018
@alexcrichton
Copy link
Member Author

@bors: rollup

kennytm added a commit to kennytm/rust that referenced this pull request Feb 27, 2018
@kennytm
Rollup merge of rust-lang#48548 - alexcrichton:msvc-linker-utf16, r=a…
2b114da 
…lexcrichton

Encode linker arguments as UTF-16 on MSVC platforms

This is a forward-port of rust-lang#48455 to the master branch
@kennytm kennytm mentioned this pull request Feb 27, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Feb 28, 2018
@kennytm
Rollup merge of rust-lang#48548 - alexcrichton:msvc-linker-utf16, r=a…
59ab146 
…lexcrichton

Encode linker arguments as UTF-16 on MSVC platforms

This is a forward-port of rust-lang#48455 to the master branch
@kennytm kennytm mentioned this pull request Feb 28, 2018
Merged
bors added a commit that referenced this pull request Feb 28, 2018
@bors
Auto merge of #48608 - kennytm:rollup, r=kennytm
0ff9872 
Rollup of 15 pull requests

- Successful merges: #48266, #48321, #48365, #48381, #48450, #48473, #48479, #48484, #48488, #48497, #48541, #48548, #48558, #48560, #48565
- Failed merges:
@bors bors merged commit 5db73fc into rust-lang:master Feb 28, 2018
@alexcrichton alexcrichton deleted the msvc-linker-utf16 branch March 3, 2018 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @bors @Mark-Simulacrum @petrochenkov