rustc: Spawn cmd /c for .bat scripts
#47505
Merged
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an accidental regression rust-lang#46335 where the behavior of `Path::ends_with` is different from `str::ends_with` (paths operate over components, strs operate over chars).
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @oli-obk (just a heads up) |
alexcrichton
added
beta-nominated
|
@bors r+ rollup |
|
📌 Commit 6defae3 has been approved by |
|
@alexcrichton do I need to create the PR against beta? I haven't done a backport before. |
|
@estebank nah no worries! As a reviewer you're not on the hook for the backport. I'll take care of this once it merges |
kennytm
added
the
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 17, 2018
…on, r=estebank rustc: Spawn `cmd /c` for `.bat` scripts This fixes an accidental regression rust-lang#46335 where the behavior of `Path::ends_with` is different from `str::ends_with` (paths operate over components, strs operate over chars).
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 17, 2018
…on, r=estebank rustc: Spawn `cmd /c` for `.bat` scripts This fixes an accidental regression rust-lang#46335 where the behavior of `Path::ends_with` is different from `str::ends_with` (paths operate over components, strs operate over chars).
bors
added a commit
that referenced
this pull request
Jan 17, 2018
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an accidental regression #46335 where the behavior of
Path::ends_withis different fromstr::ends_with(paths operate overcomponents, strs operate over chars).