modernize smallintmap module #4733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch to explicit self * get rid of the @ box * replace DVec with ~[] (to get rid of the mutable field) * implement the new container::Map trait
catamorphism
added a commit
that referenced
this pull request
Feb 1, 2013
modernize smallintmap module
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a proper owned data structure without an @ box and a mutable field (from DVec), and implements the core::container::Map trait.
The old module is still around as
oldsmallintmap.rsand migrating over to the new module seems like it will involve dealing with switching to explicit self and getting rid of mutable fields in the librustc code (at least without boxing it in @ again). I gave it a try but it turned into a bigger mess than I felt like dealing with today.Closes #4693 and #2347, and another bug can be opened about migrating away from the old module.