Update clippy #46937
Closed
Update clippy #46937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @oli-obk |
|
You need to run x.py to update the Cargo.lock |
|
pushed |
|
@bors r+ |
|
📌 Commit 5935f1f has been approved by |
kennytm
added
the
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 23, 2017
Update clippy Unbreaks it rust-lang/rust-clippy#2289
|
🔒 Merge conflict |
kennytm
added
S-waiting-on-author
|
@Manishearth Would you mind reviving this (rebase on rust master + update clippy to latest master)? Clippy (and miri as well) needs to be test-pass before branching off to the next beta. |
|
Clippy and miri aren't distributed, why is the beta blocked on them passing? |
|
@oli-obk it is tested in the same manner as RLS and rustfmt. Anyway, this is unblocked on 1.24-beta by not testing them. |
|
Superseded by #47172. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbreaks it
rust-lang/rust-clippy#2289