Skip to content

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Dec 10, 2017

fixes #44808

@rust-highfive
Copy link
Contributor

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm
Copy link
Member

kennytm commented Dec 10, 2017

CI is failing.

[00:04:17] error: unused import: `std::collections::BTreeMap`
[00:04:17]   --> /checkout/src/libtest/lib.rs:60:5
[00:04:17]    |
[00:04:17] 60 | use std::collections::BTreeMap;
[00:04:17]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:04:17]    |
[00:04:17] note: lint level defined here
[00:04:17]   --> /checkout/src/libtest/lib.rs:35:9
[00:04:17]    |
[00:04:17] 35 | #![deny(warnings)]
[00:04:17]    |         ^^^^^^^^
[00:04:17]    = note: #[deny(unused_imports)] implied by #[deny(warnings)]
[00:04:17] 
[00:04:17] error[E0609]: no field `metrics` on type `&mut ConsoleTestState<T>`
[00:04:17]    --> /checkout/src/libtest/lib.rs:892:28
[00:04:17]     |
[00:04:17] 892 |                         st.metrics.insert_metric(test.name.as_slice(),
[00:04:17]     |                            ^^^^^^^
[00:04:17] 
[00:04:17] error: aborting due to 2 previous errors
[00:04:17] 
[00:04:17] error: Could not compile `test`.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 10, 2017
@bjorn3 bjorn3 force-pushed the remove-test-metric branch from c5a0841 to 83c08d2 Compare December 10, 2017 13:30
@kennytm
Copy link
Member

kennytm commented Dec 10, 2017

@bors r+ rollup

cc #19145.

@bors
Copy link
Collaborator

bors commented Dec 10, 2017

📌 Commit 83c08d2 has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2017
@bors
Copy link
Collaborator

bors commented Dec 10, 2017

⌛ Testing commit 83c08d2 with merge 2537a49...

bors added a commit that referenced this pull request Dec 10, 2017
@bors
Copy link
Collaborator

bors commented Dec 10, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 2537a49 to master...

@bors bors merged commit 83c08d2 into rust-lang:master Dec 10, 2017
@bors bors mentioned this pull request Dec 10, 2017
@bjorn3 bjorn3 deleted the remove-test-metric branch December 11, 2017 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test::TestFn::(Static|Dyn)MetricFn seems to be unused
4 participants