Allow region pointer to unsafe pointer casts in const expressions. #4634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
|
That is: r? @nikomatsakis |
Contributor
|
r-. @jdm, see suggestions. I realized we can be a bit more liberal here and also simplify the code you wrote. Sorry I didn't advise you this way before. |
Contributor
Author
|
No worries, the comments are excellent, and I'm touching code I don't have too much experience with. |
Contributor
Author
|
Hmm, using demand::assign is giving me errors like this: Any ideas? |
Contributor
|
@jdm -- hmm, I'm not sure, can you push the code somewhere I can play with it? or ping me on irc tomorrow. |
Contributor
|
Closing because this has been open for a while with no activity. @jdm , please submit a new pull request if needed -- thanks! |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Oct 15, 2025
native-lib: bump libffi
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Oct 15, 2025
native-lib: bump libffi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nmatsakis