Skip to content

Add structured suggestions for various "use" suggestions #46035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2017
Merged

Add structured suggestions for various "use" suggestions #46035

merged 2 commits into from
Nov 22, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 16, 2017 •
edited
Loading

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2017
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 18, 2017

📌 Commit b83cad5 has been approved by petrochenkov

@petrochenkov petrochenkov added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2017
@bors
Copy link
Collaborator

bors commented Nov 18, 2017

⌛ Testing commit b83cad55c76da792a99a9a435886eb5028a0f4ac with merge ccea48ed23af6c9c456ba35da02c3216f1d78d0c...

@bors
Copy link
Collaborator

bors commented Nov 19, 2017

💔 Test failed - status-travis

kennytm
kennytm reviewed Nov 19, 2017
View reviewed changes
src/test/ui/issue-35976.stderr Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs to be deleted due to recent contributions:

 error: the `wait` method cannot be invoked on a trait object
   --> $DIR/issue-35976.rs:24:9
    |
 24 |     arg.wait();
    |         ^^^^
-   |
 help: another candidate was found in the following trait, perhaps add a `use` for it:
    |
 11 | use private::Future;
    |
 
 error: aborting due to previous error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 19, 2017
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 20, 2017

📌 Commit 2c2891b has been approved by petrochenkov

@petrochenkov petrochenkov added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2017
@bors
Copy link
Collaborator

bors commented Nov 22, 2017

⌛ Testing commit 2c2891b with merge bb7d5dd0904b3f3d60afba97dd057cd9f512f5b7...

@bors
Copy link
Collaborator

bors commented Nov 22, 2017

💔 Test failed - status-appveyor

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 22, 2017

spurious?

---- changing_bin_features_caches_targets stdout ----
	running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe run`
running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe run --features foo`
thread 'changing_bin_features_caches_targets' panicked at '
Expected: execs
    but: exited with exit code: 101
--- stdout
--- stderr
   Compiling foo v0.0.1 (file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/cit/t3/foo)
error: failed to link or copy `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t3\foo\target\debug\deps\foo-f76c704c72dc1115.exe` to `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t3\foo\target\debug\foo.exe`
Caused by:
  Access is denied. (os error 5)
', C:\Users\appveyor\.cargo\registry\src\github.202132.xyz-1ecc6299db9ec823\hamcrest-0.1.1\src\core.rs:31:12
note: Run with `RUST_BACKTRACE=1` for a backtrace.
---- changing_bin_paths_common_target_features_caches_targets stdout ----
	running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe run`
running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe clean -p a`
running `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe run`
thread 'changing_bin_paths_common_target_features_caches_targets' panicked at '
Expected: execs
    but: exited with exit code: 101
--- stdout
--- stderr
   Compiling a v0.0.1 (file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/cit/t2/foo/a)
error: failed to link or copy `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t2\foo\./target\debug\deps\a-a478fe7568e0eb90.exe` to `C:\projects\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\cit\t2\foo\./target\debug\a.exe`
Caused by:
  Access is denied. (os error 5)
', C:\Users\appveyor\.cargo\registry\src\github.202132.xyz-1ecc6299db9ec823\hamcrest-0.1.1\src\core.rs:31:12
failures:
    changing_bin_features_caches_targets
    changing_bin_paths_common_target_features_caches_targets

@kennytm
Copy link
Member

kennytm commented Nov 22, 2017

@bors retry

Not sure, but feels spurious

@bors
Copy link
Collaborator

bors commented Nov 22, 2017

⌛ Testing commit 2c2891b with merge 45594d5...

bors added a commit that referenced this pull request Nov 22, 2017
@bors
Auto merge of #46035 - oli-obk:use_suggestions, r=petrochenkov
45594d5 
Add structured suggestions for various "use" suggestions

r? @petrochenkov
@bors
Copy link
Collaborator

bors commented Nov 22, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 45594d5 to master...

@bors bors merged commit 2c2891b into rust-lang:master Nov 22, 2017
@oli-obk oli-obk deleted the use_suggestions branch December 8, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oli-obk @petrochenkov @bors @kennytm