Skip to content

Conversation

@vramana
Copy link
Contributor

@vramana vramana commented Nov 10, 2017

Fixes #45702

  • Add Tests

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Nov 10, 2017

r? @nikomatsakis

Can you update the tests per the instructions in this gist? Specifically these tests:

  • src/test/compile-fail/issue-25579.rs
  • src/test/compile-fail/borrowck/borrowck-mut-borrow-linear-errors.err

@vramana vramana force-pushed the fix-45702 branch 2 times, most recently from b4fc1ed to fbb7df0 Compare November 10, 2017 23:10
@vramana vramana changed the title [WIP] Fix MIR borrowck EndRegion not found Fix MIR borrowck EndRegion not found Nov 10, 2017
//[mir]~^ ERROR (Ast) [E0499]
//[mir]~| ERROR (Mir) [E0506]
//[mir]~| ERROR (Mir) [E0499]
//[mir]~| ERROR (Mir) [E0499]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arielb1 -- is there an existing issue for these multiple reports? I didn't see anything obvious in the spreadsheet, seems like we should file one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 10, 2017

📌 Commit fbb7df0 has been approved by nikomatsakis

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 11, 2017
@bors
Copy link
Collaborator

bors commented Nov 15, 2017

⌛ Testing commit fbb7df0 with merge f93a492...

bors added a commit that referenced this pull request Nov 15, 2017
Fix MIR borrowck EndRegion not found

Fixes #45702

- [x] Add Tests
@bors
Copy link
Collaborator

bors commented Nov 15, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing f93a492 to master...

@bors bors merged commit fbb7df0 into rust-lang:master Nov 15, 2017
@vramana vramana deleted the fix-45702 branch December 26, 2017 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants