rustc: Don't create empty codegen units #45035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This'll end up just creating a bunch of object files that otherwise wouldn't exist, so skip that extra work if possible.
|
@bors r+ Yes, I don't think there's a reason to do this anymore (and there never might have been one except for the pre-existing assertions). Thanks, Alex! |
|
📌 Commit a70c5cb has been approved by |
shepmaster
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 9, 2017
rustc: Don't create empty codegen units This'll end up just creating a bunch of object files that otherwise wouldn't exist, so skip that extra work if possible.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This'll end up just creating a bunch of object files that otherwise wouldn't
exist, so skip that extra work if possible.