Skip to content

Fix run button #44671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2017
Merged

Fix run button #44671

merged 1 commit into from
Sep 18, 2017

Conversation

GuillaumeGomez
Copy link
Member

r? @QuietMisdreavus

Before:

before

After:

after

Quite urgent.

@steveklabnik
Copy link
Contributor

Is this the right way to fix this? How'd this bug get introduced?

@GuillaumeGomez
Copy link
Member Author

Because of a position change in the pre tags. Because of this, the run button "relative" parent became the global parent.

@steveklabnik
Copy link
Contributor

Gotcha, thanks.

@bors: r+

@bors
Copy link
Collaborator

bors commented Sep 18, 2017

📌 Commit 90ce24a has been approved by steveklabnik

@GuillaumeGomez
Copy link
Member Author

@bors: p=1

@bors
Copy link
Collaborator

bors commented Sep 18, 2017

⌛ Testing commit 90ce24a with merge c6d00f65142ebe7c56a411aa3c5dfaf9e687be4f...

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 18, 2017
@alexcrichton
Rollup merge of rust-lang#44671 - GuillaumeGomez:run-button, r=stevek…
cfa32bf 
…labnik

Fix run button

r? @QuietMisdreavus

Before:

![before](https://user-images.githubusercontent.com/3050060/30538927-612c6a44-9c70-11e7-9ca2-f3860d880b95.png)

After:

![after](https://user-images.githubusercontent.com/3050060/30538929-6416ea0e-9c70-11e7-990a-7e4fbf5d7319.png)

Quite urgent.
@alexcrichton alexcrichton mentioned this pull request Sep 18, 2017
Closed
@carols10cents carols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 18, 2017
@alexcrichton
Copy link
Member

@bors: retry

  • prioritizing rollup with this in it

bors added a commit that referenced this pull request Sep 18, 2017
@bors
Auto merge of #44676 - alexcrichton:rollup, r=alexcrichton
4a8bc8a 
Rollup of 10 pull requests

- Successful merges: #44364, #44466, #44537, #44640, #44651, #44657, #44661, #44668, #44671, #44675
- Failed merges:
@bors
Copy link
Collaborator

bors commented Sep 18, 2017

⌛ Testing commit 90ce24a with merge 0da835202813349565ca7a7f17013a96fc85759d...

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 18, 2017
@alexcrichton
Rollup merge of rust-lang#44671 - GuillaumeGomez:run-button, r=stevek…
929215d 
…labnik

Fix run button

r? @QuietMisdreavus

Before:

![before](https://user-images.githubusercontent.com/3050060/30538927-612c6a44-9c70-11e7-9ca2-f3860d880b95.png)

After:

![after](https://user-images.githubusercontent.com/3050060/30538929-6416ea0e-9c70-11e7-990a-7e4fbf5d7319.png)

Quite urgent.
@alexcrichton alexcrichton mentioned this pull request Sep 18, 2017
Merged
@alexcrichton
Copy link
Member

@bors: retry

prioritizing rollup again

@bors
Copy link
Collaborator

bors commented Sep 18, 2017

⌛ Testing commit 90ce24a with merge e856750b93231e34ec266b1c2558e4e83e43d388...

@alexcrichton
Copy link
Member

@bors: retry

  • prioritizing rollup

bors added a commit that referenced this pull request Sep 18, 2017
@bors
Auto merge of #44678 - alexcrichton:rollup, r=alexcrichton
0701b37 
Rollup of 11 pull requests

- Successful merges: #44364, #44466, #44537, #44548, #44640, #44651, #44657, #44661, #44668, #44671, #44675
- Failed merges:
@GuillaumeGomez
Copy link
Member Author

Thanks @alexcrichton!

@bors
Copy link
Collaborator

bors commented Sep 18, 2017

⌛ Testing commit 90ce24a with merge 0701b37...

@bors bors merged commit 90ce24a into rust-lang:master Sep 18, 2017
@GuillaumeGomez GuillaumeGomez deleted the run-button branch September 19, 2017 07:52
@Manishearth Manishearth mentioned this pull request Sep 21, 2017
Closed
@Manishearth Manishearth mentioned this pull request Jul 16, 2020
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 16, 2020
@Manishearth
Don't position:relative on all pres
c621a54 
We need it for run buttons (rust-lang#44671), but not function defs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @steveklabnik @bors @alexcrichton @carols10cents @QuietMisdreavus