- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
          std: Mark Layout::repeat as #[inline]
          #43513
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override)  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional to have #[no_mangle] repeated here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, nope!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this not work on system LLVMs? Is it the typical behavior where LLVM doesn't recognize our allocation functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah unfortunately only our LLVM sees our allocation functions.
76fbe16    to
    289142d      
    Compare
  
    | 
           @bors r+  | 
    
| 
           📌 Commit 289142d has been approved by   | 
    
| 
           @bors rollup  | 
    
…Sushi std: Mark `Layout::repeat` as `#[inline]` This fixes an optimization regression by allowing LLVM to see through more functions. Closes rust-lang#43272
| 
           @bors r-  | 
    
289142d    to
    06ee8b3      
    Compare
  
    This fixes an optimization regression by allowing LLVM to see through more functions. Closes rust-lang#43272
06ee8b3    to
    54b6b23      
    Compare
  
    | 
           @bors: r=BurntSushi  | 
    
    
      
        1 similar comment
      
    
  
    | 
           @bors: r=BurntSushi  | 
    
| 
           📌 Commit 54b6b23 has been approved by   | 
    
…Sushi std: Mark `Layout::repeat` as `#[inline]` This fixes an optimization regression by allowing LLVM to see through more functions. Closes rust-lang#43272
This fixes an optimization regression by allowing LLVM to see through more
functions.
Closes #43272