rustc_llvm: re-run build script when env var LLVM_CONFIG changes #42985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also add the rerun-if-changed to |
|
@Mark-Simulacrum Done! |
|
Looks good to me. Thanks! @bors r+ rollup |
|
📌 Commit 4f13da7 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 30, 2017
…ulacrum rustc_llvm: re-run build script when env var LLVM_CONFIG changes This removes the changes done in rust-lang#42429 and use the newly introduced `cargo:rerun-if-env-changed` in rust-lang/cargo#4125. As `LLVM_CONFIG` env var points to the `llvm-config` and changes when it gets configured in `config.toml` or removed from it, we can re-run the build script if this env var changes. closes rust-lang#42444 r? @alexcrichton
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 30, 2017
…ulacrum rustc_llvm: re-run build script when env var LLVM_CONFIG changes This removes the changes done in rust-lang#42429 and use the newly introduced `cargo:rerun-if-env-changed` in rust-lang/cargo#4125. As `LLVM_CONFIG` env var points to the `llvm-config` and changes when it gets configured in `config.toml` or removed from it, we can re-run the build script if this env var changes. closes rust-lang#42444 r? @alexcrichton
shepmaster
added
the
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 30, 2017
…ulacrum rustc_llvm: re-run build script when env var LLVM_CONFIG changes This removes the changes done in rust-lang#42429 and use the newly introduced `cargo:rerun-if-env-changed` in rust-lang/cargo#4125. As `LLVM_CONFIG` env var points to the `llvm-config` and changes when it gets configured in `config.toml` or removed from it, we can re-run the build script if this env var changes. closes rust-lang#42444 r? @alexcrichton
bors
added a commit
that referenced
this pull request
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the changes done in #42429 and use the newly introduced
cargo:rerun-if-env-changedin rust-lang/cargo#4125.As
LLVM_CONFIGenv var points to thellvm-configand changes when it gets configured inconfig.tomlor removed from it, we can re-run the build script if this env var changes.closes #42444
r? @alexcrichton