Skip to content

Conversation

ollie27
Copy link
Contributor

@ollie27 ollie27 commented Jun 9, 2017

Currently rustdoc will fail if passed -o foo/doc if the foo
directory doesn't exist.

Also remove unneeded mkdir as create_dir_all can now handle
concurrent invocations since #39799.

Currently rustdoc will fail if passed `-o foo/doc` if the `foo`
directory doesn't exist.

Also remove unneeded `mkdir` as `create_dir_all` can now handle
concurrent invocations.
@Mark-Simulacrum
Copy link
Member

r? @GuillaumeGomez

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2017
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+

@bors
Copy link
Collaborator

bors commented Jun 12, 2017

📌 Commit 577c059 has been approved by GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Jun 12, 2017

⌛ Testing commit 577c059 with merge 0a5218b...

bors added a commit that referenced this pull request Jun 12, 2017
rustdoc: Use `create_dir_all` to create output directory

Currently rustdoc will fail if passed `-o foo/doc` if the `foo`
directory doesn't exist.

Also remove unneeded `mkdir` as `create_dir_all` can now handle
concurrent invocations since #39799.
@bors
Copy link
Collaborator

bors commented Jun 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing 0a5218b to master...

@bors bors merged commit 577c059 into rust-lang:master Jun 12, 2017
@ollie27 ollie27 deleted the rustdoc_create_dir_all branch June 12, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants