Rollup of 9 pull requests #42367
Closed
Rollup of 9 pull requests #42367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now marks a few whitelisted extensions as executable in the tarball, so Windows packages can be extracted on other platforms and directly execute install.sh. It also includes a fix for the chmod on bulk dirs, so now the html docs won't be marked executable en masse. Fixes rust-lang#42121 r? @alexcrichton
Changed all the tests except test_range_step to use Iterator::step_by.
Only exposed as DeprecatedStepBy (as of PR 41439)
Byteswapping Fingerprints when encoding is unnessesary and breaks if the Fingerprint is later decoded on a machine with different endianness to the one it was encoded on. Fix by removing the Encodable and Decodable implementations and use the ones derived from RustcEncodable and RustcDecodable. Fixes rust-lang#42239
Also store the array length as a usize rather than a String. This is just a minor refactor.
This option forwards to each `cargo test` invocation, and applies the same logic across all test steps to keep going after failures. At the end, a brief summary line reports how many commands failed, if any. Note that if a test program fails to even start at all, or if an auxiliary build command related to testing fails, these are still left to stop everything right away. Fixes rust-lang#40219.
Support VS 2017 Fixes rust-lang#38584 This replaces all the MSVC linker logic with that from the 'gcc' crate. The code looks the same, but there could be regressions. I've only tested this with x86_64. r? @alexcrichton cc @vadimcn @retep998
…alexcrichton Deprecate range-specific `step_by` Deprecation attributes and test updates only. Was replaced by an any-iterator version in rust-lang#41439 Last follow-up (this release) to rust-lang#42110 (comment) r? @alexcrichton
…sakis Improve error message for const extern fn It's currently ``error: unmatched visibility `pub` ``, which is a nonsensical error in this context.
…oerister Don't byteswap Fingerprints when encoding Byteswapping Fingerprints when encoding is unnessesary and breaks if the Fingerprint is later decoded on a machine with different endianness to the one it was encoded on. Fixes rust-lang#42239 This PR fixes a regression caused by rust-lang#42082. @michaelwoerister
…crichton Update rust-installer for Windows executable mode It now marks a few whitelisted extensions as executable in the tarball, so Windows packages can be extracted on other platforms and directly execute install.sh. It also includes a fix for the chmod on bulk dirs, so now the html docs won't be marked executable en masse. Fixes rust-lang#42121 r? @alexcrichton
…=alexcrichton Reduce verbosity of build logs This does two separate things. - Sets sccache logging to warn instead of info. - Makes tests when running for a given PR (not on auto branch) quiet. (cc @eddyb) r? @alexcrichton
Syntax highlight rust code in librustc/dep_graph/README.md
…illaumeGomez rustdoc: Rename `Vector` and `FixedVector` to `Slice` and `Array` Also store the array length as a usize rather than a String. This is just a minor refactor.
rustbuild: Add `./x.py test --no-fail-fast` This option forwards to each `cargo test` invocation, and applies the same logic across all test steps to keep going after failures. At the end, a brief summary line reports how many commands failed, if any. Note that if a test program fails to even start at all, or if an auxiliary build command related to testing fails, these are still left to stop everything right away. Fixes rust-lang#40219.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=10 |
|
📌 Commit d85ce57 has been approved by |
|
⌛ Testing commit d85ce57 with merge 3d0320c... |
|
💔 Test failed - status-travis |
|
Issue seems to be the emscripten build |
|
Failure may be due to #42354. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step_by#42310, Improve error message for const extern fn #42319, Don't byteswap Fingerprints when encoding #42335, Update rust-installer for Windows executable mode #42343, Reduce verbosity of build logs #42354, Syntax highlight rust code in librustc/dep_graph/README.md #42355, rustdoc: RenameVectorandFixedVectortoSliceandArray#42360, rustbuild: Add./x.py test --no-fail-fast#42363