Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Part of #42229.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2017
@GuillaumeGomez
Copy link
Member Author

cc @Susurrus

@Susurrus
Copy link
Contributor

LGTM, though I didn't compile or run-test it.

@GuillaumeGomez
Copy link
Member Author

@bors: r=Susurrus

@bors
Copy link
Collaborator

bors commented May 29, 2017

📌 Commit 2969137 has been approved by Susurrus

@bors
Copy link
Collaborator

bors commented May 29, 2017

⌛ Testing commit 2969137 with merge cb7c60f...

bors added a commit that referenced this pull request May 29, 2017
@bors
Copy link
Collaborator

bors commented May 30, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Susurrus
Pushing cb7c60f to master...

@bors bors merged commit 2969137 into rust-lang:master May 30, 2017
@GuillaumeGomez GuillaumeGomez deleted the new-error-codes branch May 30, 2017 08:14
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 1, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants