Rollup of 4 pull requests #39956
Closed
Rollup of 4 pull requests #39956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Feb 19, 2017
GuillaumeGomez
commented
- Successful merges: Variable Bindings possible nitpick #39923, Fix spelling in hashmap comments #39937, Fix indentation of error message #39940, Docs: Better explanation of return values for min, max functions for the Iterator trait #39955
- Failed merges:
Complete drive by nitpick I'm afraid
So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit.
Explain that a None is returned if the iterator is empty.
Variable Bindings possible nitpick Complete drive by nitpick I'm afraid
Fix spelling in hashmap comments Fixing my bad english from rust-lang#38368 Note to self: triple check spelling/grammar
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
Docs: Better explanation of return values for min, max functions for the Iterator trait Added an explanation that `None` is returned if an iterator is empty. Also added examples for `max` and `min`. I chose not to add examples for other functions like `max_by_key` etc. so that the examples stay concised and focused on the main functionality.
|
@bors: r+ p=1 |
|
📌 Commit a7405db has been approved by |
|
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit a7405db with merge 111f3ee... |
|
💔 Test failed - status-travis |
|
@bors: retry |
|
⌛ Testing commit a7405db with merge 252e345... |
|
💔 Test failed - status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.