doc comment rewording #39482
Merged
doc comment rewording #39482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
frewsxcv
reviewed
Feb 6, 2017
src/librustc/mir/mod.rs
Outdated
| @@ -63,7 +63,7 @@ macro_rules! newtype_index { | |||
| } | |||
|
|
|||
| /// Lowered representation of a single function. | |||
| // Do not implement clone for Mir, its easy to do so accidently and its kind of expensive. | |||
| /// Do not implement clone for Mir, which can be accidently done and kind of expensive. | |||
There was a problem hiding this comment.
Looks good!
Regarding your // to /// change, I'm not sure if this information belongs in the doc comment. What do you think?
There was a problem hiding this comment.
Yes, better to keep it out of doc comment. Thanks
|
@frewsxcv Updated |
|
Looks good, thanks! @bors r+ rollup |
|
📌 Commit 380ba6d has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 7, 2017
doc comment rewording
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 7, 2017
doc comment rewording
bors
added a commit
that referenced
this pull request
Feb 7, 2017
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 8, 2017
doc comment rewording
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 8, 2017
doc comment rewording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.