Add more docs for CoerceUnsized and Unsize #38816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
coercion-doc
branch
from
ac0dc35 to
9688e8d
Compare
strega-nil
reviewed
Jan 4, 2017
src/libcore/marker.rs
Outdated
There was a problem hiding this comment.
Should be T is Unsize<Trait> when T: Trait, in order to be consistent with the above sentence.
src/libcore/ops.rs
Outdated
There was a problem hiding this comment.
"For builtin types" sounds unclear; perhaps reword this to say something to the effect of "for builtin pointer types".
src/libcore/ops.rs
Outdated
There was a problem hiding this comment.
small nit; where U: ?Sized is, afaik, not valid syntax. Another argument for supporting it?
There was a problem hiding this comment.
Yes. The docs also output this form. There is no reason not to support it IMO.
Manishearth
force-pushed
the
coercion-doc
branch
from
9688e8d to
07e844f
Compare
|
Updated. |
|
Thanks! @bors: r+ rollup |
|
📌 Commit 07e844f has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 4, 2017
…meGomez Add more docs for CoerceUnsized and Unsize here be dragons r? @ubsan @steveklabnik
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jan 4, 2017
…meGomez Add more docs for CoerceUnsized and Unsize here be dragons r? @ubsan @steveklabnik
|
cc @rust-lang/lang to make sure the docs fit our beliefs |
sanxiyn
added a commit
to sanxiyn/rust
that referenced
this pull request
Jan 10, 2017
…meGomez Add more docs for CoerceUnsized and Unsize here be dragons r? @ubsan @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here be dragons
r? @ubsan @steveklabnik