Rollup of 7 pull requests #35086
Merged
Rollup of 7 pull requests #35086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tuple structs the where clause comes after the definition.
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=20 |
|
📌 Commit e9b5f3a has been approved by |
|
⌛ Testing commit e9b5f3a with merge cc74333... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
@bors r+ |
|
📌 Commit bc283bb has been approved by |
Make vec::Drain and binary_heap::Drain covariant I removed all mutable pointers/references, and added covariance tests similar to the ones in rust-lang#32635. It builds and passes the tests, but I noticed that there weren't any tests of Drain's behaviour (at least not in libcollectionstest), so I'm not sure if my changes accidently broke Drain's behaviour. Should I add some tests for that (and if so, what should the tests include)?
resolve: Fix ICE and extra diagnostics happening when unresolved imports are used in patterns Closes rust-lang#34933 r? @jseyfried
Avoid processing `feature`s on unconfigured crates Fixes rust-lang#34932, a regression caused by rust-lang#34272. r? @nrc
…xcrichton
move coerce-match{,-calls} into run-pass-valgrind
Closes rust-lang#21696.
… r=alexcrichton rustdoc: Fix tuple struct where clause rendering For tuple structs the where clause comes after the definition. Fixes rust-lang#34928
…sakis Use &mut for `CombineFields` in inference relations Because dropping obligations on the floor makes a mess. r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Jul 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
features on unconfigured crates #34969, move coerce-match{,-calls} into run-pass-valgrind #35013, rustdoc: Fix tuple struct where clause rendering #35037, Use &mut forCombineFieldsin inference relations #35040, Add non-panicking abs() functions to all signed integer types. #35058