Skip to content

Fix issue where rustbuild expected msvc to have ar #34302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2016
Merged

Fix issue where rustbuild expected msvc to have ar #34302

merged 1 commit into from
Jun 17, 2016

Conversation

retep998
Copy link
Contributor

I made cc2ar return an Option.

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+ e0992df

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 16, 2016
@Manishearth
Rollup merge of rust-lang#34302 - retep998:🐇-sanity-is-overrated-🐇, r…
51b20bc 
…=alexcrichton

Fix issue where rustbuild expected msvc to have ar

I made `cc2ar` return an `Option`.

r? @alexcrichton
@Manishearth Manishearth mentioned this pull request Jun 16, 2016
Merged
bors added a commit that referenced this pull request Jun 17, 2016
@bors
Auto merge of #34315 - Manishearth:rollup, r=Manishearth
114be1e 
Rollup of 4 pull requests

- Successful merges: #34298, #34302, #34307, #34312
- Failed merges:
@bors bors merged commit e0992df into rust-lang:master Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@retep998 @alexcrichton @bors