Skip to content

Conversation

srinivasreddy
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@srinivasreddy
Copy link
Contributor Author

cc @nrc

let autoderef = this.read_struct_field("autoderef", 0, Decodable::decode)
.unwrap();
Ok((autoderef,
ty::MethodCallee {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closure body of read_struct is twice indented, is that intentional?

Copy link
Contributor

@marcusklaas marcusklaas May 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say no, but opinions diverge on this subject. That's a related, but different issue though.

@bors
Copy link
Collaborator

bors commented Jun 10, 2016

☔ The latest upstream changes (presumably #34095) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

Closing due to inactivity, but feel free to reopen with a rebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants