Skip to content

Conversation

GuillaumeGomez and others added 11 commits May 15, 2016 15:29
`nest_level` is long dead since cac7a20
(PR rust-lang#14831), so is `check_positional_ok()`. Let's bid them farewell.
This query is frequently used during trait selection and caching the
result can be a reasonable performance win.
…tsakis

syntax_ext: format: nest_level's are no more

Just noticed this while working on rust-lang#33642 and here's a quick fix, shouldn't touch anything else. It's some historic code indeed...
…yle, r=steveklabnik

Fix selected item background style

r? @steveklabnik
Add missing code fence to `diagnostics.rs`

Closes rust-lang#33662
…turon

introduce a specializes cache

This query is frequently used during trait selection and caching the
result can be a reasonable performance win.

The one case I examined thus far was the mrusty package (v0.5.1), where I saw an improvement in "typeck item bodies" from ~8.3s to ~1.9s.

r? @aturon
@Manishearth
Copy link
Member Author

@bors r+ p=10

@bors
Copy link
Collaborator

bors commented May 18, 2016

📌 Commit 07194a0 has been approved by Manishearth

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Collaborator

bors commented May 18, 2016

⌛ Testing commit 07194a0 with merge 9743c66...

bors added a commit that referenced this pull request May 18, 2016
Rollup of 5 pull requests

- Successful merges: #33656, #33666, #33673, #33675, #33695
- Failed merges:
@bors bors merged commit 07194a0 into rust-lang:master May 18, 2016
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants