commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/rust-lang/rust/commit/f9d4149c29e8b989fa3624993be379f380e48dcf/hovercard" href="https://github.com/rust-lang/rust/commit/f9d4149c29e8b989fa3624993be379f380e48dcf">rust-lang@f9d4149 which was part of this pull request: rust-lang#26025 Consider the following two lines from that commit: rust-lang@f9d4149#diff-a3b24dbe2ea7c1981f9ac79f9745f40aL462 rust-lang@f9d4149#diff-a3b24dbe2ea7c1981f9ac79f9745f40aL469 The purpose of these lines is to register LLVM passes. Prior to the that commit, the passes being handled were assumed to be ModulePasses (a specific type of LLVM pass) since they were being added to a ModulePass manager. After that commit, both lines were refactored (presumably in an attempt to DRY out the code), but the ModulePasses were changed to be registered to a FunctionPass manager. This change resulted in ModulePasses being run, but a Function object was being passed as a parameter to the pass instead of a Module, which resulted in segmentation faults. In this commit, I changed relevant sections of the code to check the type of the passes being added and register them to the appropriate pass manager. Closes rust-lang#31067

Register LLVM passes with the correct LLVM pass manager.#31176bors merged 1 commit intorust-lang:masterrust-lang/rust:masterfrom frewsxcv:incorrect-pass-kindfrewsxcv/rust:incorrect-pass-kindCopy head branch name to clipboard

Commits

Commits on Jan 25, 2016

Register LLVM passes with the correct LLVM pass manager.

Register LLVM passes with the correct LLVM pass manager.#31176
bors merged 1 commit intorust-lang:masterfrom
frewsxcv:incorrect-pass-kind