Skip to content

Disable the null check elimination pass #30165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2015
Merged

Disable the null check elimination pass #30165

merged 1 commit into from
Dec 3, 2015

Conversation

dotdash
Copy link
Contributor

@dotdash dotdash commented Dec 2, 2015

This pass causes mis-optimizations in some cases and is probably no
longer really important for us, so let's disable it for now.

Fixes #30081

@dotdash
Disable the null check elimination pass
d7ccea6 
This pass causes mis-optimizations in some cases and is probably no
longer really important for us, so let's disable it for now.

Fixes rust-lang#30081
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ d7ccea6

Thanks!

@brson brson added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. I-nominated labels Dec 2, 2015
@brson
Copy link
Contributor

brson commented Dec 2, 2015

This affects beta too.

@brson
Copy link
Contributor

brson commented Dec 2, 2015

cc @rust-lang/compiler

Edit: I'm just going to do the port.

@brson brson added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed I-nominated labels Dec 2, 2015
@brson brson mentioned this pull request Dec 2, 2015
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 2, 2015
@bors
Copy link
Collaborator

bors commented Dec 2, 2015

⌛ Testing commit d7ccea6 with merge abfadfe...

bors added a commit that referenced this pull request Dec 2, 2015
@bors
Auto merge of #30165 - dotdash:no_null_elim, r=alexcrichton
abfadfe 
This pass causes mis-optimizations in some cases and is probably no
longer really important for us, so let's disable it for now.

Fixes #30081
@bors
Copy link
Collaborator

bors commented Dec 3, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit d7ccea6 into rust-lang:master Dec 3, 2015
@dotdash dotdash deleted the no_null_elim branch January 31, 2016 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dotdash @rust-highfive @alexcrichton @brson @bors