Skip to content

Update 'Strings' chapter of the book #29846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2015
Merged

Update 'Strings' chapter of the book #29846

merged 3 commits into from
Nov 15, 2015

Conversation

JanLikar
Copy link
Contributor

Fix #29823 by further explaining &str and pointing out the
difference between &str and &'static str.

Fix rust-lang#29823 by further explaining `&str` and pointing out the
difference between `&str` and `&'static str`.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

`"Hello there."` is a string literal and its type is `&'static str`. String
literal is a string slice that is statically allocated, meaning that it’s saved
inside our compiled program, and exists for the entire duration it runs. The
`greeting` binding is a reference to this statically allocated string.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we be clearer here? Say that it can be used anywhere &str is expected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...

compiled program, and exists for the entire duration it runs. The `greeting`
binding is a reference to this statically allocated string. String slices
have a fixed size, and cannot be mutated.
`"Hello there."` is a string literal and its type is `&'static str`. String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/String/A string/

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 15, 2015

📌 Commit 8bcbcae has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thank you!

@bors
Copy link
Collaborator

bors commented Nov 15, 2015

⌛ Testing commit 8bcbcae with merge 68f8122...

bors added a commit that referenced this pull request Nov 15, 2015
Fix #29823 by further explaining `&str` and pointing out the
difference between `&str` and `&'static str`.
@bors bors merged commit 8bcbcae into rust-lang:master Nov 15, 2015
@JanLikar JanLikar deleted the #29823 branch November 15, 2015 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants