-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Update 'Strings' chapter of the book #29846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix rust-lang#29823 by further explaining `&str` and pointing out the difference between `&str` and `&'static str`.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
`"Hello there."` is a string literal and its type is `&'static str`. String | ||
literal is a string slice that is statically allocated, meaning that it’s saved | ||
inside our compiled program, and exists for the entire duration it runs. The | ||
`greeting` binding is a reference to this statically allocated string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we be clearer here? Say that it can be used anywhere &str
is expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure...
compiled program, and exists for the entire duration it runs. The `greeting` | ||
binding is a reference to this statically allocated string. String slices | ||
have a fixed size, and cannot be mutated. | ||
`"Hello there."` is a string literal and its type is `&'static str`. String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/String/A string/
@bors: r+ rollup |
📌 Commit 8bcbcae has been approved by |
Thank you! |
Fix #29823 by further explaining `&str` and pointing out the difference between `&str` and `&'static str`.
Fix #29823 by further explaining
&str
and pointing out thedifference between
&str
and&'static str
.