Skip to content

Remove some trivial transmutes #29131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2015
Merged

Remove some trivial transmutes #29131

merged 1 commit into from
Oct 18, 2015

Conversation

apasel422
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

`rbml::writer::Encoder::unsafe_clone` had no users across the entire
repo.
@apasel422
Copy link
Contributor Author

Outside of test code, there are two remaining uses of std::mem::transmute_copy in the entire repo: the default implementation of Repr::repr in libcore/raw.rs and the str::split_at_mut method in libcore/str/mod.rs. For the latter, the corresponding method for [T] is implemented using raw pointers instead.

@bluss
Copy link
Member

bluss commented Oct 18, 2015

@bors r+

Great! Sounds like we should fix str::split_at_mut too

@bors
Copy link
Collaborator

bors commented Oct 18, 2015

📌 Commit 6031a58 has been approved by bluss

@bors
Copy link
Collaborator

bors commented Oct 18, 2015

⌛ Testing commit 6031a58 with merge 140e793...

bors added a commit that referenced this pull request Oct 18, 2015
@bors bors merged commit 6031a58 into rust-lang:master Oct 18, 2015
@apasel422 apasel422 deleted the transmute branch October 18, 2015 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants