Skip to content

Improve std::io::ErrorKind #27885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2015
Merged

Conversation

steveklabnik
Copy link
Member

Hopefully make this distinction a little more clear.

Fixes #27637
r? @alexcrichton /cc @Havvy

@alexcrichton
Copy link
Member

This seems like a bit of a step backwards to me by making InvalidInput a little more vague (generalizing "parameter" to "input state") and taking away the docs of InvalidData (which I think are basically saying the same thing). It may just be worth clarifying that InvalidData typically doesn't show up because of I/O errors perhaps?

@steveklabnik
Copy link
Member Author

@alexcrichton I'm down. What do you think about this version?

@Havvy
Copy link
Contributor

Havvy commented Aug 19, 2015

It literally reads to me as "IO errors will not cause this kind of IO Error Kind". Perhaps something of the line of "For example, a function that reads a file into a String will error with InvalidData if the file is not valid UTF-8."

Hopefully make this distinction a little more clear.

Fixes rust-lang#27637
@steveklabnik
Copy link
Member Author

@Havvy sounds good, what about this revision?

@alexcrichton
Copy link
Member

@bors: r+ 7c06c5a rollup

@bors
Copy link
Collaborator

bors commented Aug 19, 2015

⌛ Testing commit 7c06c5a with merge 3a407b6...

bors added a commit that referenced this pull request Aug 19, 2015
Hopefully make this distinction a little more clear.

Fixes #27637 
r? @alexcrichton /cc @Havvy
@alexcrichton
Copy link
Member

Looks like our android bot is MIA but all tests passed so merging manually.

@alexcrichton alexcrichton merged commit 7c06c5a into rust-lang:master Aug 21, 2015
@steveklabnik steveklabnik deleted the gh27637 branch June 19, 2016 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants