Skip to content

Conversation

dhuseby
Copy link

@dhuseby dhuseby commented Jul 20, 2015

fixes the linking error on bitrig.

@rust-highfive
Copy link
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

You should be actually able to delete archive_format entirely I believe? You may also want to investigate and see if gnu is the format for these archives (I'm not sure what linkers broadly accept by default...).

This may also just indicate a bug in LLVM's implementation? Unsure :(

@dhuseby
Copy link
Author

dhuseby commented Jul 23, 2015

@alexcrichton the goal of Bitrig is to not use any GNU software so using the default ar is the correct solution. Let me remove it and double check that it builds.

@alexcrichton
Copy link
Member

Oh "gnu" in this case is just the format of the archive, not the actual tooling used to produce it.

@dhuseby
Copy link
Author

dhuseby commented Jul 23, 2015

@alexcrichton what's wrong with using the built-in ar?

@alexcrichton
Copy link
Member

It generally works, but there are a number of wins for not depending on it:

  • Running our own in-process ar is much speedier (no forking, less copying, etc)
  • When cross compiling it's one less tool we have to find. For example cross compiling to bitrig is in theory easier if we don't run the system ar
  • Helps us eventually remove this code path altogether (calling the system ar). We want to move to using LLVM's tooling as much as possible to ensure a consistent experience.

@dhuseby
Copy link
Author

dhuseby commented Jul 23, 2015

@alexcrichton alright, I tested "gnu" and it works just fine, let's go with that. rebased and fixed.

@alexcrichton
Copy link
Member

@bors: r+ b208bd9

@alexcrichton
Copy link
Member

@bors: rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 24, 2015
…excrichton

fixes the linking error on bitrig.
bors added a commit that referenced this pull request Jul 24, 2015
@bors bors merged commit b208bd9 into rust-lang:master Jul 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants