Skip to content

fix for ICE issue #25180 #25209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

fix for ICE issue #25180 #25209

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
96229e8
fixed ICE issue #25180
llogiq May 8, 2015
29daa29
formatting correction
llogiq May 8, 2015
1434715
crossed the i-s and dotted the t-s ;-) Also added a run-pass test and…
llogiq May 8, 2015
ca5c694
Pulled walk_fn() into Var mode, extended test
llogiq May 10, 2015
6e19cfa
more tests
llogiq May 10, 2015
a18ce4d
fixed errors in test code
llogiq May 10, 2015
4eec41a
Removed println! from test
llogiq May 12, 2015
3715898
added feature declaration
llogiq May 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/librustc/middle/check_const.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,8 @@ impl<'a, 'tcx, 'v> Visitor<'v> for CheckCrateVisitor<'a, 'tcx> {
b: &'v ast::Block,
s: Span,
fn_id: ast::NodeId) {
assert!(self.mode == Mode::Var);
self.with_euv(Some(fn_id), |euv| euv.walk_fn(fd, b));
self.with_mode(Mode::Var, |v| v.with_euv(Some(fn_id),
|euv| euv.walk_fn(fd, b)));
visit::walk_fn(self, fk, fd, b, s);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

walk_fn has to be inside the with_mode call, too.

}

Expand Down
16 changes: 16 additions & 0 deletions src/test/run-pass/issue-25180.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// pretty-expanded FIXME #25180
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure was in pretty tests, which I don't you can do if you're using macros like println! which use unstable items in their expansions.


const x: &'static Fn() = &|| println!("ICE here");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do multiple statements, arguments and local variables work in these closures?


fn main() {}