Rollup of PRs in the queue; Friday #23548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two borrowing examples were confusing/misleading. This changes it to more clearly show how you _can_ borrow a box, and also uses & instead of &*.
Multiple people have been suprised by this aspect of read_line's behavior, which is not obvious from the docs.
This fixes several use cases that were broken after rust-lang#23265 landed.
We don't use 'task' anymore, these are now threads. Because this changes the name of a compiler option, this is [breaking-change]
`uppercase` and `lowercase` are currently named `to_uppercase` and `to_lowercase`. Also adds a link to the `char` type documentation which has much more detail on these iterators.
…erflow-bug, r=alexcrichton This should solve issues rust-lang#23115, rust-lang#23469, and rust-lang#23407. As the title says, this is just a workaround. The underlying problem is that macro expansion can produce invalid spans. I've opened issue rust-lang#23480 so we don't forget about that.
…veklabnik This was added for rust-lang#23241.
As @alexcrichton says, this was really a libgreen thing, and isn't relevant now. As this removes a technically-public function, this is a [breaking-change] Conflicts: src/libtest/lib.rs
|
@bors: r+ p=20 |
|
📌 Commit 4732e7f has been approved by |
|
⌛ Testing commit 4732e7f with merge ab566e0... |
|
💔 Test failed - auto-win-32-opt |
|
@bors: r+ force |
|
📌 Commit 6107e4c has been approved by |
bors
added a commit
that referenced
this pull request
Mar 20, 2015
…r=aturon The IP and socket address types all had `FromStr` implemented but the implementations were not marked stable, nor was the error type returned ready to be properly stabilized. This commit marks the implementations of `FromStr` as stable and also renamed the `ParseError` structure to `AddrParseError`. The error is now also an opaque structure that cannot be constructed outside the standard library. cc rust-lang#22949 [breaking-change]
…hton We don't use 'task' anymore, these are now threads. Because this changes the name of a compiler option, this is [breaking-change] I think this is small enough to not need an RFC, nor a period of accepting both. If we want to take both for a while, I can change the patch.
…labnik These two borrowing examples were confusing/misleading. This changes it to more clearly show how you _can_ borrow a box, and also uses & instead of &*.
Multiple people have been suprised by this aspect of read_line's behavior, which is not obvious from the docs.
The wiki doesn't seem to exist
This fixes several use cases that were broken after rust-lang#23265 landed.
`uppercase` and `lowercase` are currently named `to_uppercase` and `to_lowercase`. Also adds a link to the `char` type documentation which has much more detail on these iterators.
Fixes rust-lang#16330 My troff is probably poor, so make sure that all looks okay.
…r=alexcrichton As @alexcrichton says, this was really a libgreen thing, and isn't relevant now. As this removes a technically-public function, this is a [breaking-change]
This was referenced Mar 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.