Skip to content

Fix ICE: integer underflow in diagnostic.rs #22103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2015

Conversation

pczarn
Copy link
Contributor

@pczarn pczarn commented Feb 8, 2015

Fixes #22091

I'm not sure how to write a test for this. An ICE happens with spans that start near (after?) a null character or some other zero-width unicode character.

@rust-highfive
Copy link
Contributor

r? @nick29581

(rust_highfive has picked a reviewer for you, use r? to override)

@pczarn pczarn changed the title syntax: Fix integer underflow in diagnostic Fix ICE: integer underflow in diagnostic.rs Feb 8, 2015
@nrc
Copy link
Member

nrc commented Feb 9, 2015

@bors r+ 89b2e9f

@bors
Copy link
Collaborator

bors commented Feb 9, 2015

⌛ Testing commit 89b2e9f with merge 91a0401...

@bors
Copy link
Collaborator

bors commented Feb 9, 2015

💔 Test failed - auto-win-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Feb 10, 2015
Fixes rust-lang#22091

I'm not sure how to write a test for this. An ICE happens with spans that start near (after?) a null character or some other zero-width unicode character.
@bors bors merged commit 89b2e9f into rust-lang:master Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange ICE in a linter when using syntax extensions
5 participants