replace deprecated uint references with u32 in trpl/looping.md #20956
Conversation
Replaced uint references with u32 to prevent compiler warnings.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
There was a problem hiding this comment.
Strictly speaking, you can put no suffix and get the same code (well, it would use i32), but I'm not sure if that effects the meaning steve was going for.
There was a problem hiding this comment.
If no suffix is preferred in this case, I'd be happy to make that change instead, and create a new PR. I was mostly interested in clearing compiler warnings due to the deprecated uint type.
There was a problem hiding this comment.
I think we can take this for now as a strict improvement, actually.
There was a problem hiding this comment.
I generally want to have no type where we can.
replace deprecated uint references with u32 in trpl/looping.md Reviewed-by: Gankro
minor: Fix building with DHAT
minor: Fix building with DHAT
6 participants
Replaced uint references with u32 to prevent compiler warnings.