Skip to content

Conversation

@piyo
Copy link
Contributor

@piyo piyo commented Jan 11, 2015

Solves #20853.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@piyo
Copy link
Contributor Author

piyo commented Jan 11, 2015

I don't know what github is doing, but my pull request for #20853 is at #20920.

Also for a test driver, please take a look at piyo/rust@issue-20853-test-driver-in-c

bors added a commit that referenced this pull request Jan 12, 2015
Give mmap a page-aligned stack start address

Reviewed-by: Aatch
@bors bors merged commit 0568464 into rust-lang:master Jan 12, 2015
lnicola pushed a commit to lnicola/rust that referenced this pull request Nov 4, 2025
fix: Resolve `target-dir` more precisely
lnicola pushed a commit to lnicola/rust that referenced this pull request Nov 11, 2025
fix: Resolve `target-dir` more precisely
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants