Skip to content

Conversation

csouth3
Copy link
Contributor

@csouth3 csouth3 commented Jan 4, 2015

#[deriving] has been changed to #[derive], so we should update this lint accordingly so that it remains consistent with the language.

Also register the rename with the LintStore.

I've changed the one reference to raw_pointer_deriving that occurs in the tests (as well as renamed the file appropriately), but the rest of the raw_pointer_derivings in the Rust codebase will need to wait for a snapshot to be changed because stage0 doesn't know about the new lint name. I'll take care of the remaining renaming after the next snapshot.

Closes #20498.

Due to the `#[deriving]` -> `#[derive]` switch.
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 5, 2015
`#[deriving]` has been changed to `#[derive]`, so we should update this lint accordingly so that it remains consistent with the language.

Also register the rename with the LintStore.

I've changed the one reference to `raw_pointer_deriving` that occurs in the tests (as well as renamed the file appropriately), but the rest of the `raw_pointer_deriving`s in the Rust codebase will need to wait for a snapshot to be changed because stage0 doesn't know about the new lint name.  I'll take care of the remaining renaming after the next snapshot.

Closes rust-lang#20498.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 6, 2015
`#[deriving]` has been changed to `#[derive]`, so we should update this lint accordingly so that it remains consistent with the language.

Also register the rename with the LintStore.

I've changed the one reference to `raw_pointer_deriving` that occurs in the tests (as well as renamed the file appropriately), but the rest of the `raw_pointer_deriving`s in the Rust codebase will need to wait for a snapshot to be changed because stage0 doesn't know about the new lint name.  I'll take care of the remaining renaming after the next snapshot.

Closes rust-lang#20498.
@bors bors merged commit 8cebb1f into rust-lang:master Jan 6, 2015
@csouth3 csouth3 deleted the derive-lint branch January 6, 2015 19:36
lnicola pushed a commit to lnicola/rust that referenced this pull request Sep 1, 2025
…selected

convert_integer_literal not on selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

raw_pointer_deriving lint name should be raw_pointer_derive

5 participants