liballoc does not need liblibc under certain configurations #20237
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
This should be g2g. The second commit was needed because the 100 char lint. The third fixes preexisting bugs. |
|
Looks good to me, |
|
Yup, I am building core through collections, and an allocator in a separate crate, all with cargo and everything is working great! I see that "feature" isn't the ideal word for this, but seeing that's what cargo offers I can only hope a stray feature behind the facade is better than one on it. |
|
Huh, I thought I saw this get approved awhile ago. Sorry this has been sitting for awhile @Ericson2314! I'm not sure that we'll want to commit long-term to a strategy like this, but I'm pretty ok with this for now as it's basically just an experimental crate. So long as it builds for master continuously, we should be good! |
|
No worries at all, cmr did r+ it, but then i pushed more commits. Yeah long term the allocator API will render messing with liballoc unnecessary I assume. Thank you both! |
…crichton libc is only used when the heap allocations are not defined externally, or defined in another crate. I assume these extern* configurations were added for the sake of those of us experimenting with freestanding Rust. Avoiding libc where possible is often very important for us.
This allows the vanilla libary to built for kernel use with Cargo.
…ure = external_*)
libc is only used when the heap allocations are not defined externally, or defined in another crate. I assume these extern* configurations were added for the sake of those of us experimenting with freestanding Rust. Avoiding libc where possible is often very important for us.
7 participants
libc is only used when the heap allocations are not defined externally, or defined in another crate. I assume these extern* configurations were added for the sake of those of us experimenting with freestanding Rust. Avoiding libc where possible is often very important for us.