Skip to content

Conversation

selaine
Copy link
Contributor

@selaine selaine commented Dec 22, 2014

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

Oh wow I forgot about this, nice catch and thanks!

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 22, 2014
@bors bors merged commit 98ed882 into rust-lang:master Dec 23, 2014
@selaine selaine deleted the less-asm branch December 23, 2014 10:31
lnicola added a commit to lnicola/rust that referenced this pull request Jul 7, 2025
…al_to_const-assist-tosyntaxeditor

Migrate `promote_local_to_const` Assist to `SyntaxEditor`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants