Refactor QPath to take an ast::TraitRef #18868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton |
|
Tidy error |
nikomatsakis
force-pushed
the
issue-17388-unbound-path-assoc-type
branch
2 times, most recently
from
ae03e92 to
420de27
Compare
bors
added a commit
that referenced
this pull request
Nov 19, 2014
…oc-type, r=pcwalton This fixes #17388. Note that we don't check type parameters in trait-references and so on, so we accept some nonsense (I opened #18865). (It may be easier to just add support for `T::Foo` and deprecate the qpath code until we can implement it more robustly using the trait lookup infrastructure, not sure.)
nikomatsakis
force-pushed
the
issue-17388-unbound-path-assoc-type
branch
from
420de27 to
b64c7b8
Compare
This was referenced Nov 20, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #17388.
Note that we don't check type parameters in trait-references and so on, so we accept some nonsense (I opened #18865). (It may be easier to just add support for
T::Fooand deprecate the qpath code until we can implement it more robustly using the trait lookup infrastructure, not sure.)