Fix obscure ICE in trans (#18514) #18518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some obscure circumstances, failure to do this can cause unsubstituted type parameters to show up where they aren't expected and cause an ICE. Closes #18514
|
Also closes #17810, I think. I edited the PR description accordingly but it'd be good to double check once this lands. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 3, 2014
lnicola
added a commit
to lnicola/rust
that referenced
this pull request
Nov 18, 2024
minor: Bump xshell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't ICE when translating a generic impl method from an extern crate that contains a match expression on a local variable lvalue where one of the match case bodies contains an expression that autoderefs through an overloaded generic deref impl and we neglect to monomorphize the result type of the deref method.
Closes #17810
Closes #18514