Skip to content

Conversation

alexcrichton
Copy link
Member

According to valgrind these bytes are always uninitialized, which I don't
understand because the memory is always allocated with mem::zeroed(), but just
to be safe set sin6_flowinfo to 0 unconditionally.

According to valgrind these bytes are always uninitialized, which I don't
understand because the memory is always allocated with mem::zeroed(), but just
to be safe set sin6_flowinfo to 0 unconditionally.
@thestinger
Copy link
Contributor

It seems like we should identify the underlying issue, as it could indicate a real bug in zeroed or a broken optimization.

@brson
Copy link
Contributor

brson commented Sep 17, 2014

I'm also concerned about the root cause here.

I don't necessarily oppose the explicit initialization, but worried about papering over a potential unknown compiler bug.

@alexcrichton
Copy link
Member Author

Ok, I'll see if I have time to investigate this later on then.

@alexcrichton alexcrichton deleted the valgrind-annoyances branch September 22, 2014 17:25
lnicola pushed a commit to lnicola/rust that referenced this pull request Jun 23, 2024
…rpolation, r=Veykril

style: simplify string interpolation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants