net: Fix some valgrind annoyances #17315
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to valgrind these bytes are always uninitialized, which I don't understand because the memory is always allocated with mem::zeroed(), but just to be safe set sin6_flowinfo to 0 unconditionally.
|
It seems like we should identify the underlying issue, as it could indicate a real bug in |
|
I'm also concerned about the root cause here. I don't necessarily oppose the explicit initialization, but worried about papering over a potential unknown compiler bug. |
|
Ok, I'll see if I have time to investigate this later on then. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 23, 2024
…rpolation, r=Veykril style: simplify string interpolation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to valgrind these bytes are always uninitialized, which I don't
understand because the memory is always allocated with mem::zeroed(), but just
to be safe set sin6_flowinfo to 0 unconditionally.