Improve memory usage of libsyntax #17223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces some usage of `.to_string()` with `.into_string()` Signed-off-by: Peter Atashian <[email protected]>
|
Graph of memory usage comparison while building librustc: |
| @@ -121,7 +121,7 @@ impl fmt::Show for RcStr { | |||
| impl RcStr { | |||
| pub fn new(string: &str) -> RcStr { | |||
| RcStr { | |||
| string: Rc::new(string.to_string()), | |||
| string: Rc::new(string.into_string()), | |||
There was a problem hiding this comment.
(FWIW, I guess is the change that is making the noticable difference; everything else seems minor.)
|
Another solution to this issue would be #16544 but since |
|
@retep998 what did you use to generate that graph? |
|
@tshepang A program I wrote using WinAPI to record the memory usage of rustc, and then Excel to turn the data into a graph. |
bors
added a commit
that referenced
this pull request
Sep 17, 2014
Replaces some usage of `.to_string()` with `.into_string()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces some usage of
.to_string()with.into_string()