Rollup of 9 pull requests #149132

matthiaskrgr · 2025-11-20T10:15:58Z

Successful merges:

Add doc for va_list APIs #146925 (Add doc for va_list APIs)
alloc: fix Debug implementation of ExtractIf #147035 (alloc: fix Debug implementation of ExtractIf)
Add support for hexagon-unknown-qurt target #147173 (Add support for hexagon-unknown-qurt target)
rustc_public: Make Id types !Send / !Sync #148261 (rustc_public: Make Id types !Send / !Sync)
ignore unsized types in mips64 and sparc64 callconvs #149041 (ignore unsized types in mips64 and sparc64 callconvs)
fix the fragment_in_dst_padding_gets_overwritten test on s390x #149056 (fix the fragment_in_dst_padding_gets_overwritten test on s390x)
Add test scaffolding for the remote-test-client #149071 (Add test scaffolding for the remote-test-client)
rustc-dev-guide subtree update #149095 (rustc-dev-guide subtree update)
[AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers #149108 ([AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…in-branch Explain `bors try parent=<sha>` and replace uses of `master` with `main` in all relevant files

... inspired from downstream default branch name change

update mentions of default branch of rust-lang/rust

sembr implementing_new_features.md and improve it a bit

sembr stabilization_guide.md and improve it a bit

sembr implementing_new_features.md again

https://github.com/actions/checkout?tab=readme-ov-file#checkout-v5

ci: avoid sembr getting rebuilt on every push

sembr sanitizers.md again

add missing " and -Zoffload=Enable flag

Add doc for va_list APIs I observed that [PR146521](rust-lang#146521) submitted two weeks ago resolved some documentation issues related to `VaListImpl`, similar to the previous [PR136969](rust-lang#136969). This PR specifically adds requirements about argument availability for `VaListImpl::arg`, and also adds safety descriptions to the three associated intrinsic APIs.

alloc: fix `Debug` implementation of `ExtractIf` I noticed this while reviewing rust-lang#141032. Calling `get` on the inner `Vec` never returns `Some` as the `Vec`'s length is temporarily set to zero while the `ExtractIf` exists.

…vidtwco,tgross35 Add support for hexagon-unknown-qurt target MCP: rust-lang/compiler-team#919 Fixes rust-lang#148982.

…celinval rustc_public: Make Id types !Send / !Sync These types are Id's to a table stored in TLS, so using them from another tread will either panic, or give wrong results. Therefor, I've added a ~~`ReferencesTls`~~`ThreadLocalIndex` marker type, which ensures types arn't `Send`/`Sync`. This is a breaking change for users of the `rustc_public` crate. ~~It also changes how `DefId` and similar are `Serialize`d. It would be possible to preserve the old behavior if that's needed, but I couldn't see any tests for these.~~ EDIT: Not anymore: rust-lang#148261 (comment) Zulip Discussion: https://rust-lang.zulipchat.com/#narrow/channel/320896-project-stable-mir/topic/WDYM.20.22should.20not.20.20be.20shared.20across.20threads.22/with/547374171

…nsized, r=bjorn3 ignore unsized types in mips64 and sparc64 callconvs Non-rustic calling conventions should not make up an ABI for unsized types (cc rust-lang#148302). The vast majority of our callconv implementations already ignore unsized types, `sparc64` and `mips64` I guess were missed. r? `````@bjorn3`````

…rite, r=RalfJung fix the fragment_in_dst_padding_gets_overwritten test on s390x on s390x 128bit types have a smaller alignment then on x86[^1]. This leads to smaller structs (24 instead of 32 bytes) and therefore the write_unaligned will write outside of the structs boundary. To fix the test, change the trailing u32 into a u8. This will generate 7 trailing padding bytes on s390x and 15 on x86_64. Also change the start of the garbage data so it will span over x,y and padding: ``` s390x: XXXXXXXXXXXXXXXXY------- x86_64: XXXXXXXXXXXXXXXXY--------------- GGGGGGGG ``` [^1]: s390x ELF ABI Table 1.1, Page 12 https://github.com/IBM/s390x-abi

…-timeout-tests, r=jieyouxu Add test scaffolding for the `remote-test-client` r? ``@jieyouxu``

rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@61ad195. Created using https://github.com/rust-lang/josh-sync. r? `````@ghost`````

…r=Noratrieb [AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers Amy has effectively been helping to maintain these Power targets for a while, so add her to the maintainers list.

matthiaskrgr · 2025-11-20T10:16:15Z

@bors r+ rollup=never p=5

bors · 2025-11-20T10:16:19Z

📌 Commit 8613f0e has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-11-20T13:25:20Z

⌛ Testing commit 8613f0e with merge 7281a3b...

bors · 2025-11-20T16:39:58Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 7281a3b to main...

github-actions · 2025-11-20T16:42:42Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2c0f486 (parent) -> 7281a3b (this PR)

Test differences

Show 33 test diffs

Stage 0

spec::tests::hexagon_unknown_qurt: [missing] -> pass (J0)
tests::serialize_allocid: [missing] -> pass (J0)
tests::serialize_cratenum: [missing] -> pass (J0)
tests::serialize_defid: [missing] -> pass (J0)
tests::serialize_instancedef: [missing] -> pass (J0)
tests::serialize_layout: [missing] -> pass (J0)
tests::serialize_mirconstid: [missing] -> pass (J0)
tests::serialize_span: [missing] -> pass (J0)
tests::serialize_ty: [missing] -> pass (J0)
tests::serialize_tyconstid: [missing] -> pass (J0)
tests::serialize_variantidx: [missing] -> pass (J0)
test_help: [missing] -> pass (J5)

Stage 1

[assembly] tests/assembly-llvm/targets/targets-elf.rs#hexagon_unknown_qurt: [missing] -> pass (J0)
spec::tests::hexagon_unknown_qurt: [missing] -> pass (J1)
tests::serialize_allocid: [missing] -> pass (J1)
tests::serialize_cratenum: [missing] -> pass (J1)
tests::serialize_defid: [missing] -> pass (J1)
tests::serialize_instancedef: [missing] -> pass (J1)
tests::serialize_layout: [missing] -> pass (J1)
tests::serialize_mirconstid: [missing] -> pass (J1)
tests::serialize_span: [missing] -> pass (J1)
tests::serialize_ty: [missing] -> pass (J1)
tests::serialize_tyconstid: [missing] -> pass (J1)
tests::serialize_variantidx: [missing] -> pass (J1)
vec::extract_if_debug: [missing] -> pass (J4)

Stage 2

vec::extract_if_debug: [missing] -> pass (J2)
[assembly] tests/assembly-llvm/targets/targets-elf.rs#hexagon_unknown_qurt: [missing] -> pass (J3)

Additionally, 6 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7281a3bc4b89a010aed05528d648450feb8b69d3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 3636.9s -> 5296.1s (+45.6%)
aarch64-apple: 8168.0s -> 11181.3s (+36.9%)
dist-x86_64-apple: 7182.5s -> 9435.9s (+31.4%)
dist-aarch64-apple: 5728.5s -> 7486.8s (+30.7%)
x86_64-rust-for-linux: 2424.8s -> 2961.9s (+22.1%)
x86_64-gnu-llvm-20: 2314.1s -> 2781.7s (+20.2%)
aarch64-gnu-llvm-20-1: 3360.5s -> 3972.1s (+18.2%)
i686-gnu-nopt-1: 6895.1s -> 8138.8s (+18.0%)
x86_64-gnu-llvm-21-2: 5125.2s -> 6004.6s (+17.2%)
aarch64-gnu-llvm-20-2: 2175.8s -> 2506.6s (+15.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-20T16:42:42Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#146925	Add doc for va_list APIs	`dec1565cc94ea6e7bfd94c883e0e40588d083103` (link)
#147035	alloc: fix `Debug` implementation of `ExtractIf`	`59aa68118b41e18d5de826f514df79389e52a415` (link)
#147173	Add support for hexagon-unknown-qurt target	`7fc6c4d1111e6c2619fc3970c8fbbdcab4a01d1f` (link)
#148261	rustc_public: Make Id types !Send / !Sync	`616332776a44810448cec5c7ee89793510af1ec6` (link)
#149041	ignore unsized types in mips64 and sparc64 callconvs	`ea97dd9e373da290bf311b4d9cc3fff2598bf619` (link)
#149056	fix the fragment_in_dst_padding_gets_overwritten test on s3…	`ab3fac5419868034877d4e9005578cc181680073` (link)
#149071	Add test scaffolding for the `remote-test-client`	`e4b17634c9a19b3d93402ec638a49058696bae13` (link)
#149095	rustc-dev-guide subtree update	`c55d6ffd43a24e17e19617c8a8e2bdbdd0dfc63c` (link)
#149108	[AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers	`1fc38e2dd6634ae868e147c1c4223f5c2c129aa5` (link)

previous master: 2c0f4860cc

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-11-20T17:59:45Z

Finished benchmarking commit (7281a3b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.8%	[-1.8%, -1.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.8%	[-1.8%, -1.8%]	1

Cycles

Results (secondary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.1%	[2.1%, 5.2%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-4.9%, -3.1%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.681s -> 472.196s (0.11%)
Artifact size: 388.90 MiB -> 388.85 MiB (-0.01%)

joboet and others added 30 commits September 25, 2025 17:48

alloc: fix Debug implementation of ExtractIf

0909712

add doc for va_list APIs

0d6a313

describe bors try parent=sha builds

d8b6752

update some uses of master in the devguide

9d1c273

Merge pull request rust-lang#2640 from jdonszelmann/try-parent-and-ma…

8c1cb5b

…in-branch Explain `bors try parent=<sha>` and replace uses of `master` with `main` in all relevant files

some updates and improvements

f6bc9d5

... inspired from downstream default branch name change

Merge pull request rust-lang#2639 from rust-lang/tshepang/default-branch

4fd2b77

update mentions of default branch of rust-lang/rust

sembr implementing_new_features.md

7b0c218

typo

4a845a6

add date marker

de3b053

reduce overlong physical lines

407da40

needless repetition

0f497ce

Merge pull request rust-lang#2641 from rust-lang/tshepang/sembr

7b35dd1

sembr implementing_new_features.md and improve it a bit

do not ignore lines that are list entries

6d42077

avoid surprising string handling behavior

e4ef199

sembr src/stabilization_guide.md

5517b2c

some text improvements

aefdfa8

Merge pull request rust-lang#2642 from rust-lang/tshepang/sembr

9d16bc4

sembr stabilization_guide.md and improve it a bit

sembr implementing_new_features.md again

74caf6d

Merge pull request rust-lang#2643 from rust-lang/tshepang/sembr

cf542b5

sembr implementing_new_features.md again

use latest checkout action

d5f14ae

https://github.com/actions/checkout?tab=readme-ov-file#checkout-v5

ci: avoid sembr getting rebuilt on every push

662facc

ci: run sembr in release mode

e7cd6c6

Merge pull request rust-lang#2644 from rust-lang/tshepang/ci

d2a8e42

ci: avoid sembr getting rebuilt on every push

sembr sanitizers.md again

a70b5c6

sembr: update lockfile

fe3871f

handle another edge case

5d1dc38

Merge pull request rust-lang#2645 from rust-lang/tshepang/sembr

9ce4c1a

sembr sanitizers.md again

add missing " and -Zoffload=Enable flag

3dcaf9b

Merge pull request rust-lang#2646 from rust-lang/update-offload-docs

2bf2f44

add missing " and -Zoffload=Enable flag

daltenty and others added 10 commits November 19, 2025 15:09

[AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers

a74d572

Rollup merge of rust-lang#147173 - androm3da:bcain/hexagon_qurt, r=da…

422b83a

…vidtwco,tgross35 Add support for hexagon-unknown-qurt target MCP: rust-lang/compiler-team#919 Fixes rust-lang#148982.

Rollup merge of rust-lang#149071 - ferrocene:pvdrz/remote-test-client…

37dc26c

…-timeout-tests, r=jieyouxu Add test scaffolding for the `remote-test-client` r? ``@jieyouxu``

Rollup merge of rust-lang#149095 - tshepang:rdg-sync, r=tshepang

aecee50

rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@61ad195. Created using https://github.com/rust-lang/josh-sync. r? `````@ghost`````

Rollup merge of rust-lang#149108 - daltenty:daltenty/add-maintainer, …

8613f0e

…r=Noratrieb [AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers Amy has effectively been helping to maintain these Power targets for a while, so add her to the maintainers list.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 20, 2025

bors merged commit 7281a3b into rust-lang:main Nov 20, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 20, 2025

bors mentioned this pull request Nov 20, 2025

callconv: fix mips64 aggregate argument passing for C FFI #148294

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests #149132

Rollup of 9 pull requests #149132

Uh oh!

matthiaskrgr commented Nov 20, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Nov 20, 2025

Uh oh!

bors commented Nov 20, 2025

Uh oh!

bors commented Nov 20, 2025

Uh oh!

bors commented Nov 20, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 20, 2025

Stage 0

Stage 1

Stage 2

Uh oh!

rust-timer commented Nov 20, 2025

Uh oh!

rust-timer commented Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Rollup of 9 pull requests #149132

Rollup of 9 pull requests #149132

Uh oh!

Conversation

matthiaskrgr commented Nov 20, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Nov 20, 2025

Uh oh!

bors commented Nov 20, 2025

Uh oh!

bors commented Nov 20, 2025

Uh oh!

bors commented Nov 20, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 20, 2025

Test differences

Stage 0

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 20, 2025

Uh oh!

rust-timer commented Nov 20, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

matthiaskrgr commented Nov 20, 2025 •

edited by rustbot

Loading